17.12.2020 18:50, Alan Stern пишет: > On Thu, Dec 17, 2020 at 12:40:06PM +0300, Dmitry Osipenko wrote: >> The ChipIdea driver now provides USB2 host mode support for NVIDIA Tegra >> SoCs. The ehci-tegra driver is obsolete now, remove it and redirect the >> older Kconfig entry to the CI driver. >> >> Tested-by: Matt Merhar <mattmerhar@xxxxxxxxxxxxxx> >> Tested-by: Nicolas Chauvet <kwizart@xxxxxxxxx> >> Tested-by: Peter Geis <pgwipeout@xxxxxxxxx> >> Tested-by: Ion Agorria <ion@xxxxxxxxxxx> >> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx> >> --- >> drivers/usb/host/Kconfig | 8 +- >> drivers/usb/host/Makefile | 1 - >> drivers/usb/host/ehci-tegra.c | 604 ---------------------------------- >> 3 files changed, 6 insertions(+), 607 deletions(-) >> delete mode 100644 drivers/usb/host/ehci-tegra.c >> >> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig >> index 31e59309da1f..318315602337 100644 >> --- a/drivers/usb/host/Kconfig >> +++ b/drivers/usb/host/Kconfig >> @@ -269,9 +269,13 @@ config USB_EHCI_HCD_AT91 >> config USB_EHCI_TEGRA >> tristate "NVIDIA Tegra HCD support" >> depends on ARCH_TEGRA >> - select USB_EHCI_ROOT_HUB_TT >> - select USB_TEGRA_PHY >> + select USB_CHIPIDEA >> + select USB_CHIPIDEA_HOST >> + select USB_CHIPIDEA_TEGRA >> help >> + This option is deprecated now and the driver was removed, use >> + USB_CHIPIDEA_TEGRA instead. >> + >> This driver enables support for the internal USB Host Controllers >> found in NVIDIA Tegra SoCs. The controllers are EHCI compliant. > > It doesn't really make sense to say "... the driver was removed..." > and then in the next paragraph say "This driver enables...". You > should change the second paragraph to begin: "Enable support for...". > > That's a minor matter, though, and you can easily fix it in the next > patch version. Everything else is okay. > > Acked-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> Okay, thanks.
