16.12.2020 20:58, Thierry Reding пишет: > On Tue, Dec 15, 2020 at 11:21:08PM +0300, Dmitry Osipenko wrote: >> The module alias is provided by the OF core for the OF drivers, it >> overrides the alias set by the drivers. Hence remove the unneeded macro >> in order to keep the driver code cleaner. > > This is slightly misleading because that manual MODULE_ALIAS is there > for legacy reasons and created that alias to bind against a platform > device created from board files back in the day. > > Depending on how I interpret the commit message, it also sounds like > you're suggesting that the OF core will automatically add this alias. > However, what the OF core adds is an alias based on the OF device ID > table, which is completely different. > > We don't support board files anymore and to my knowledge the aliases > generated from the OF device ID table are enough to have the driver > autoloaded, so this patch is correct. Perhaps make it clearer in the > commit message why this is no longer needed. With that: > > Acked-by: Thierry Reding <treding@xxxxxxxxxx> Alright, thanks.
