On Wed, Dec 02, 2020 at 05:27:21PM +0000, Mark Brown wrote: > On Tue, Dec 01, 2020 at 01:12:44PM -0800, Sowjanya Komatineni wrote: > > Tegra SoC has a Quad SPI controller starting from Tegra210. > > > > This patch adds support for Tegra210 QSPI controller. > > This looks pretty clean but I've got a few questions below about how > this integrates with the frameworks as well as some more minor issues. > > > +config QSPI_TEGRA > > + tristate "Nvidia Tegra QSPI Controller" > > Everything else in this file is SPI_, even the qspi controllers. > > > +++ b/drivers/spi/qspi-tegra.c > > @@ -0,0 +1,1418 @@ > > +// SPDX-License-Identifier: GPL-2.0-only > > +/* > > + * Copyright (C) 2020 NVIDIA CORPORATION. All rights reserved. > > + */ > > Please make the entire comment a C++ one. It also appears that the "All > rights reserved" here conflicts with the GPL-2.0-only SPDX statement... My understanding is that this phrase is pretty much irrelevant these days. Furthermore, I don't think this is to be interpreted as a claim to any rights other than the copyright, so it's mostly equivalent to the "Copyright (C)" on that same line. Any license terms associated with the file do still apply regardless. That said, I'm not a lawyer, so don't take this as legal advice. FWIW, there's something on the order of 8000 occurrences of that phrase in the Linux kernel sources, so I think with or without the phrase we should be okay. Thierry
Attachment:
signature.asc
Description: PGP signature
