On Wed, Nov 04, 2020 at 04:44:08PM +0300, Dmitry Osipenko wrote: > This patch fixes system shutdown on a devices that use TPS65910 as a > system's power controller. In accordance to the TPS65910 datasheet, the > PMIC's state-machine transitions into the OFF state only when DEV_OFF > bit of DEVCTRL_REG is set. The ON / SLEEP states also should be cleared, > otherwise PMIC won't get into a proper state on shutdown. Devices like > Nexus 7 tablet and Ouya game console are now shutting down properly. [...] You might want to rebase on https://lkml.org/lkml/2020/9/26/397 as it's probably going to be accepted shortly. This just means replacing register accesses: tps65910_reg_*() -> regmap_*(). Best Regards, Michał Mirosław