On Tue, 27 Oct 2020 at 14:50, Thierry Reding <thierry.reding@xxxxxxxxx> wrote: > > On Mon, Oct 26, 2020 at 01:17:14AM +0300, Dmitry Osipenko wrote: > > Use devm_platform_ioremap_resource() helper which makes code a bit > > cleaner. > > > > Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx> > > --- > > drivers/memory/tegra/tegra20-emc.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > I'm not a fan of this helper, to be honest, because I think all the > churn that we've seen with the conversions isn't really worth the 1 or 2 > lines that it saves, but hey, looks like this is pretty broadly > accepted, so if Krzysztof likes it: > > Acked-by: Thierry Reding <treding@xxxxxxxxxx> Such changes indeed do not bring much but still less local variables and -1 line. I am fine with them. They also save one error msg from devm_ioremap_resource() in case of platform_get_resource() failure. Best regards, Krzysztof
