On Fri, Oct 02, 2020 at 05:52:00PM +0300, Dmitry Osipenko wrote: > 02.10.2020 17:22, Dmitry Osipenko пишет: > > 02.10.2020 09:08, Nicolin Chen пишет: > >> static int tegra_smmu_attach_dev(struct iommu_domain *domain, > >> struct device *dev) > >> { > >> + struct iommu_fwspec *fwspec = dev_iommu_fwspec_get(dev); > >> struct tegra_smmu *smmu = dev_iommu_priv_get(dev); > >> struct tegra_smmu_as *as = to_smmu_as(domain); > >> - struct device_node *np = dev->of_node; > >> - struct of_phandle_args args; > >> unsigned int index = 0; > >> int err = 0; > > > > Looks like there is no need to initialize 'index' and 'err' variables > > anymore. > > > > Same for tegra_smmu_detach_dev(). Can remove them.