Hi Krzysztof, On Wed, Sep 30, 2020 at 09:21:39AM +0200, Krzysztof Kozlowski wrote: > On Wed, 30 Sep 2020 at 02:35, Nicolin Chen <nicoleotsuka@xxxxxxxxx> wrote: > > > > This can be used by both tegra-smmu and tegra20-devfreq drivers. > > > > Suggested-by: Dmitry Osipenko <digetx@xxxxxxxxx> > > Signed-off-by: Nicolin Chen <nicoleotsuka@xxxxxxxxx> > > --- > > > > Changelog > > v1->v2 > > * N/A > > > > drivers/memory/tegra/mc.c | 23 +++++++++++++++++++++++ > > include/soc/tegra/mc.h | 1 + > > 2 files changed, 24 insertions(+) > > > > diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c > > index ec8403557ed4..09352ad66dcc 100644 > > --- a/drivers/memory/tegra/mc.c > > +++ b/drivers/memory/tegra/mc.c > > @@ -42,6 +42,29 @@ static const struct of_device_id tegra_mc_of_match[] = { > > }; > > MODULE_DEVICE_TABLE(of, tegra_mc_of_match); > > > +struct tegra_mc *tegra_get_memory_controller(void) > > +{ > > Add kerneldoc and mention dropping of reference to the device after use. I am abort to use Dmitry's devm_ one in my next version: https://github.com/grate-driver/linux/commit/2105e7664063772d72fefe9696bdab0b688b9de2 Could I just skip the kerneldoc part? Otherwise, would you please tell me which kerneldoc file I should update? Thanks