On Wed, Sep 30, 2020 at 09:32:20AM +0300, Dmitry Osipenko wrote: > 30.09.2020 08:44, Nicolin Chen пишет: > > On Wed, Sep 30, 2020 at 08:12:10AM +0300, Dmitry Osipenko wrote: > >> 30.09.2020 03:30, Nicolin Chen пишет: > >> ... > >>> int tegra_mc_write_emem_configuration(struct tegra_mc *mc, unsigned long rate); > >>> unsigned int tegra_mc_get_emem_device_count(struct tegra_mc *mc); > >>> +struct tegra_mc *tegra_get_memory_controller(void); > >>> > >>> #endif /* __SOC_TEGRA_MC_H__ */ > >>> > >> > >> This will conflict with the tegra20-devfreq driver, you should change it > >> as well. > > > > Will remove that in v3. > > > > Thanks > > > > Please also consider to add a resource-managed variant, similar to what > I did here: > > https://github.com/grate-driver/linux/commit/2105e7664063772d72fefe9696bdab0b688b9de2 > > I was going to use it in the next iteration of the memory interconnect > series. > > But now it also will be good if you could add the devm variant to yours > SMMU patchset since you're already about to touch the tegra20-devfreq > driver. I'll then rebase my patches on top of yours patch. Just saw this reply. Yea, I think this'd be better. Thanks
