30.09.2020 08:34, Nicolin Chen пишет: > On Wed, Sep 30, 2020 at 08:10:35AM +0300, Dmitry Osipenko wrote: >> 30.09.2020 03:30, Nicolin Chen пишет: >>> void tegra_smmu_remove(struct tegra_smmu *smmu) >>> { >>> + bus_set_iommu(&platform_bus_type, NULL); >> >> Why only platform_bus? Is this really needed at all? > > I see qcom_iommu.c file set to NULL in remove(), Probably should > have added pci_bus_type too though. > > Or are you sure that there's no need at all? > It wasn't here before this patch and platform_bus is unrelated to the topic of this patch. But it probably should be there. On the other hand, the tegra_smmu_remove() is unused and maybe it could be better to get rid of this unused function at all.