On Wed, Sep 09, 2020 at 01:39:35AM +0300, Dmitry Osipenko wrote: > Technically the tegra_i2c_flush_fifos() may fail and transfer should be > aborted in this case, but this shouldn't ever happen in practice unless > there is a bug somewhere in the driver. Let's add the error check just > for completeness. > > Reviewed-by: Michał Mirosław <mirq-linux@xxxxxxxxxxxx> > Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx> > --- > drivers/i2c/busses/i2c-tegra.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Thierry Reding <treding@xxxxxxxxxx> > diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c > index 4e7d0eec0dd3..88d6e7bb14a2 100644 > --- a/drivers/i2c/busses/i2c-tegra.c > +++ b/drivers/i2c/busses/i2c-tegra.c > @@ -1177,7 +1177,9 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev, > bool dma; > u16 xfer_time = 100; > > - tegra_i2c_flush_fifos(i2c_dev); > + err = tegra_i2c_flush_fifos(i2c_dev); > + if (err) > + return err; > > i2c_dev->msg_buf = msg->buf; > i2c_dev->msg_buf_remaining = msg->len; > -- > 2.27.0 >
Attachment:
signature.asc
Description: PGP signature
