08.09.2020 11:45, Andy Shevchenko пишет: > On Tue, Sep 8, 2020 at 5:11 AM Dmitry Osipenko <digetx@xxxxxxxxx> wrote: >> >> Drop '_timeout' postfix from the wait/poll completion function names in >> order to make the names shorter, making code cleaner a tad. > > ... > >> + time_left = tegra_i2c_wait_completion(i2c_dev, &i2c_dev->msg_complete, >> + 50); > > Why not one line? > It goes over 80 chars, which is still a preferred max-length, although it's not a mandatory limit anymore. For example I have a code editor setup that is tuned for 80 chars, allowing to have multiple files viewed and edited simultaneously. But I think in the case of this particular hunk of the code, the indentation improvement would indeed overweight the code-length. I'll change it in v6, thanks!
