On Sun, Sep 6, 2020 at 9:51 PM Dmitry Osipenko <digetx@xxxxxxxxx> wrote: > > Use a single reset_control_reset() instead of assert/deasset couple in > order to make code cleaner a tad. Note that the reset_control_reset() > uses 1 microsecond delay instead of 2 that was used previously, but this > shouldn't matter. In addition don't ignore potential error of the reset > control by emitting a noisy warning if it fails, which shouldn't ever > happen in practice. Still it's not clear if you check the datasheet or not. Some elaboration would be good to have. ... > + WARN_ON_ONCE(err); Why screaming here? Wouldn't be dev_warn() enough? -- With Best Regards, Andy Shevchenko
