24.08.2020 11:28, Arend Van Spriel пишет: > > > On 8/23/2020 4:20 PM, Dmitry Osipenko wrote: >> This patch fixes SDHCI CRC errors during of RX throughput testing on >> BCM4329 chip if SDIO BUS is clocked above 25MHz. In particular the >> checksum problem is observed on NVIDIA Tegra20 SoCs. The good watermark >> value is borrowed from downstream BCMDHD driver and it's the same as the >> value used for the BCM4339 chip, hence let's re-use it for BCM4329. > > one comment, but when fixed you can add my.... > > Reviewed-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx> >> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx> >> --- >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c >> b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c >> index 3c07d1bbe1c6..ac3ee93a2378 100644 >> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c >> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c >> @@ -4278,6 +4278,7 @@ static void brcmf_sdio_firmware_callback(struct >> device *dev, int err, >> brcmf_sdiod_writeb(sdiod, SBSDIO_FUNC1_MESBUSYCTRL, >> CY_43012_MESBUSYCTRL, &err); >> break; >> + case SDIO_DEVICE_ID_BROADCOM_4329: >> case SDIO_DEVICE_ID_BROADCOM_4339: >> brcmf_dbg(INFO, "set F2 watermark to 0x%x*4 bytes for >> 4339\n", > > Maybe better to drop the chip id from the debug message. The chip id is > printed elsewhere already so it does not add info here and could only > cause confusion. Maybe you can also remove it from the 43455 message a > bit below. Hello, Arend! Thank you for the review! I'll prepare v2 with the cleaned debug messages and couple more small changes!
