On Fri, Aug 21, 2020 at 7:22 AM Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote: > > On 20-08-20, 13:37, Sudeep Holla wrote: > > On Thu, Aug 20, 2020 at 11:09:45AM +0530, Viresh Kumar wrote: > > > On 12-08-20, 01:13, Sumit Gupta wrote: > > > > Commit eaecca9e7710 ("arm64: Fix __cpu_logical_map undefined issue") > > > > fixes the issue with building tegra194 cpufreq driver as module. But > > > > the fix might cause problem while supporting physical cpu hotplug[1]. > > > > > > > > This patch fixes the original problem by avoiding use of cpu_logical_map(). > > > > Instead calling read_cpuid_mpidr() to get MPIDR on target cpu. > > > > > > > > [1] https://lore.kernel.org/linux-arm-kernel/20200724131059.GB6521@bogus/ > > > > > > > > Reviewed-by: Sudeep Holla <sudeep.holla@xxxxxxx> > > > > Signed-off-by: Sumit Gupta <sumitg@xxxxxxxxxx> > > > > --- > > > > drivers/cpufreq/tegra194-cpufreq.c | 10 +++++++--- > > > > 1 file changed, 7 insertions(+), 3 deletions(-) > > > > > > Applied. Thanks. > > > > Just to confirm, is this going as a fix ? We want to drop exporting > > cpu_logical_map in v5.9 so this needs to go as fix. I missed it earlier, > > actually, > > > > Fixes: df320f89359c ("cpufreq: Add Tegra194 cpufreq driver") > > is appropriate here so that we can drop export symbol which was part of > > Commit eaecca9e7710 ("arm64: Fix __cpu_logical_map undefined issue") > > as a workaround to fix the build. > > Okay. > > Rafael: Please pick this patch directly for next rc with > > Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx> Applied as 5.9-rc3 material with a couple of minor edits in the subject and changelog, thanks!