On 25/07/20 5:31 pm, Michał Mirosław wrote: > On Sat, Jul 25, 2020 at 11:59:39AM +0530, Rohit K Bharadwaj wrote: >> changed usage of slave (which is deprecated) to secondary without breaking the driver > > The relevant I2C and SMBus standards use master/slave terminology. Why are > you changing the names to something unfamiliar? > > If the reason are the recent coding-style changes, then please note they > are about avoiding introducing *NEW* uses of the specific words and not > about blindly replacing existing occurrences. > > Best Regards > Michał Mirosław > I'm really sorry sir, I didn't knew about this, yes the reason for my change is according to the script checkpatch.pl to suit the coding style, I would try to fix some other coding style related issues if this patch seems to be a bad idea.