On Thu, Jul 23, 2020 at 10:50:08AM +0200, Arnd Bergmann wrote: > On Thu, Jul 23, 2020 at 9:39 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > > > > Fix checkpatch warning: > > WARNING: function definition argument 'struct device *' should also have an identifier name > > > > Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> > > Is this a bug in checkpatch? I don't see why it should warn about this, > as there is no function definition here. > > Your change is clearly harmless, but I wonder if we should fix > checkpatch instead. Good point. If this were not a warning, I would ignore it. However still the common practice is to add arguments to such type definitions as it helps to describe the type. Best regards, Krzysztof
