Re: [PATCH v10 2/5] iommu/arm-smmu: ioremap smmu mmio region before implementation init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2020-07-08 06:00, Krishna Reddy wrote:
ioremap smmu mmio region before calling into implementation init.
This is necessary to allow mapped address available during vendor
specific implementation init.

Reviewed-by: Robin Murphy <robin.murphy@xxxxxxx>

Signed-off-by: Krishna Reddy <vdumpa@xxxxxxxxxx>
---
  drivers/iommu/arm-smmu.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
index d2054178df35..e03e873d3bca 100644
--- a/drivers/iommu/arm-smmu.c
+++ b/drivers/iommu/arm-smmu.c
@@ -2120,10 +2120,6 @@ static int arm_smmu_device_probe(struct platform_device *pdev)
  	if (err)
  		return err;
- smmu = arm_smmu_impl_init(smmu);
-	if (IS_ERR(smmu))
-		return PTR_ERR(smmu);
-
  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
  	ioaddr = res->start;
  	smmu->base = devm_ioremap_resource(dev, res);
@@ -2135,6 +2131,10 @@ static int arm_smmu_device_probe(struct platform_device *pdev)
  	 */
  	smmu->numpage = resource_size(res);
+ smmu = arm_smmu_impl_init(smmu);
+	if (IS_ERR(smmu))
+		return PTR_ERR(smmu);
+
  	num_irqs = 0;
  	while ((res = platform_get_resource(pdev, IORESOURCE_IRQ, num_irqs))) {
  		num_irqs++;




[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux