On 30/06/2020 12:11, Jon Hunter wrote: > > On 16/06/2020 14:52, Thierry Reding wrote: >> From: Thierry Reding <treding@xxxxxxxxxx> >> >> The standard way to do this is to list out the regulators at the top- >> level. Adopt the standard way to fix validation. >> >> Signed-off-by: Thierry Reding <treding@xxxxxxxxxx> >> --- >> .../arm64/boot/dts/nvidia/tegra132-norrin.dts | 247 ++++++------ >> .../boot/dts/nvidia/tegra186-p2771-0000.dts | 81 ++-- >> .../arm64/boot/dts/nvidia/tegra186-p3310.dtsi | 60 ++- >> .../arm64/boot/dts/nvidia/tegra194-p2888.dtsi | 96 ++--- >> .../arm64/boot/dts/nvidia/tegra210-p2180.dtsi | 23 +- >> .../arm64/boot/dts/nvidia/tegra210-p2597.dtsi | 274 +++++++------ >> .../arm64/boot/dts/nvidia/tegra210-p2894.dtsi | 361 ++++++++---------- >> .../boot/dts/nvidia/tegra210-p3450-0000.dts | 177 ++++----- >> arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 137 +++---- >> 9 files changed, 671 insertions(+), 785 deletions(-) > > > After this patch is applied I see the following build breakage ... > > DTC arch/arm64/boot/dts/nvidia/tegra210-p2894-0050-a08.dtb > arch/arm64/boot/dts/nvidia/tegra210-p2894.dtsi:1646.23-1656.4: ERROR > (phandle_references): /regulator@1: Reference to non-existent node or > label "pmic" > > arch/arm64/boot/dts/nvidia/tegra210-p2894.dtsi:1658.30-1670.4: ERROR > (phandle_references): /regulator@2: Reference to non-existent node or > label "pmic" > > arch/arm64/boot/dts/nvidia/tegra210-p2894.dtsi:1705.29-1715.4: ERROR > (phandle_references): /regulator@6: Reference to non-existent node or > label "pmic" Actually it might not be this patch. However, I noticed that builds were getting skipped when bisecting other issues. So we may need to ensure all of these build OK. Jon -- nvpublic
