On 21/06/2020 06:47, Dinghao Liu wrote: > pm_runtime_get_sync() increments the runtime PM usage counter even > when it returns an error code. Thus a pairing decrement is needed on > the error handling path to keep the counter balanced. So you have not mentioned here why you are using _noidle and not _put. Furthermore, in this patch [0] you are not using _noidle to fix the same problem in another driver. We should fix this in a consistent manner across all drivers, otherwise it leads to more confusion. Finally, Rafael mentions we should just use _put [0] and so I think we should follow his recommendation. Jon [0] https://lkml.org/lkml/2020/5/21/601 -- nvpublic
