On Fri, Jun 12, 2020 at 06:54:45PM +0300, Dmitry Osipenko wrote: > 12.06.2020 17:18, Thierry Reding пишет: > > From: Thierry Reding <treding@xxxxxxxxxx> > > > > Convert the Tegra host1x controller bindings from the free-form text > > format to json-schema. > > > > Signed-off-by: Thierry Reding <treding@xxxxxxxxxx> > > --- > ... > > + memory-controllers: > > + $ref: /schemas/types.yaml#/definitions/phandle-array > > + > > +required: > > + - compatible > > + - interrupts > > + - interrupt-names > > + - '#address-cells' > > + - '#size-cells' > > + - ranges > > + - reg > > + - clocks > > + - clock-names > > + - resets > > + - reset-names > > This memory-controllers property didn't exist before the conversion. So > this is not a pure conversion, which makes it a bit difficult to review > the changes. Could you please factor out the addition of new properties > into a separate patch? The memory-controllers property was from an earlier draft of this series and is no longer needed. I'll remove it. In my opinion, these schema conversion patches are difficult to review in general, especially the likes of this one for host1x because they are fairly complex to begin with. All existing Tegra-based device trees do pass validation (although there's a small patch needed to support the unevaluatedProperties keyword that's new in json-schema draft-08), which gives me some confidence that they are at least correct from a content point of view. Thierry
Attachment:
signature.asc
Description: PGP signature
