On Thu, Jun 4, 2020 at 12:45 PM Jon Hunter <jonathanh@xxxxxxxxxx> wrote:
>
>
> On 03/06/2020 19:41, Navid Emamdoost wrote:
> > Calling pm_runtime_get_sync increments the counter even in case of
> > failure, causing incorrect ref count. Call pm_runtime_put if
> > pm_runtime_get_sync fails.
> >
> > Signed-off-by: Navid Emamdoost <navid.emamdoost@xxxxxxxxx>
> > ---
> > drivers/dma/tegra210-adma.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/dma/tegra210-adma.c b/drivers/dma/tegra210-adma.c
> > index c4ce5dfb149b..e8c749cd3fe8 100644
> > --- a/drivers/dma/tegra210-adma.c
> > +++ b/drivers/dma/tegra210-adma.c
> > @@ -659,6 +659,7 @@ static int tegra_adma_alloc_chan_resources(struct dma_chan *dc)
> > ret = pm_runtime_get_sync(tdc2dev(tdc));
> > if (ret < 0) {
> > free_irq(tdc->irq, tdc);
> > + pm_runtime_put(tdc2dev(tdc));
> > return ret;
> > }
>
>
> Please do not send two patches with the same $subject that are fixing
> two different areas of the driver. In fact, please squash these two
> patches into a single fix and resend because they are fixing the same issue.
Sure, I will prepare a version 2 with your suggestions.
>
> Jon
>
> --
> nvpublic
--
Navid.
