Thanks for pushing a patch to fix it. I've been under the wrong
assumption that a failing pm_runtime_get_sync() wouldn't increment the
usage counter.
With Thierry's and Bjorn's comments addressed
Acked-by: Vidya Sagar <vidyas@xxxxxxxxxx>
On 20-May-20 10:07 PM, Bjorn Helgaas wrote:
External email: Use caution opening links or attachments
On Wed, May 20, 2020 at 11:59:08AM +0200, Thierry Reding wrote:
On Wed, May 20, 2020 at 04:52:23PM +0800, Dinghao Liu wrote:
pm_runtime_get_sync() increments the runtime PM usage counter even
it returns an error code. Thus a pairing decrement is needed on
s/even it/even when it/
Might also be a good idea to use a different subject prefix because I
was almost not going to look at the other patch, taking this to be a
replacement for it.
Amen. This would be a good change to start using "PCI: tegra194" or
something for pcie-tegra194.c. Or will there be tegra195, tegra 196,
etc added to this driver?
Also, please capitalize the first word and "PM" in the subjects:
PCI: tegra194: Fix runtime PM imbalance on error
Bjorn
