On Wed, May 20, 2020 at 04:40:12PM +0800, Dinghao Liu wrote: > pm_runtime_get_sync() increments the runtime PM usage counter even > it returns an error code. Thus a pairing decrement is needed on s/even it/even when it/ > the error handling path to keep the counter balanced. > > Also This driver forgets to call pm_runtime_disable() when s/Also This/Also this/ > pm_runtime_get_sync() returns an error code. > > Signed-off-by: Dinghao Liu <dinghao.liu@xxxxxxxxxx> > --- > drivers/pci/controller/pci-tegra.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Otherwise looks correct. It's came as somewhat of a surprise to me that pm_runtime_get_sync() increments the usage counter even on failure, but it does indeed. With the above fixes to the commit message: Acked-by: Thierry Reding <treding@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
