15.04.2020 12:53, Sam Ravnborg пишет: > Hi Dimitry. > > Added Laurent that is the arthitecht behind the new bridge model > briefly explained below. > > On Wed, Apr 15, 2020 at 01:20:05AM +0300, Dmitry Osipenko wrote: >> Hello, >> >> This small series adds initial support for the DRM bridges to NVIDIA Tegra >> DRM driver. This is required by newer device-trees where we model the LVDS >> encoder bridge properly. >> >> Please note that the first "Support DRM bridges" patch was previously sent >> out as a standalone v1 change. >> >> Changelog: >> >> v2: - Added the new "rgb: Don't register connector if bridge is used" >> patch, which hides the unused connector provided by the Tegra DRM >> driver when bridge is used, since bridge provides its own connector >> to us. > > We are moving to a model where the display driver have the > responsibility to create the connector - not the bridge. > > The flags argument to: > > drm_bridge_attach(encoder, bridge, previous, flags); > > is used to tell if the brigde shall create the connector or the display > driver does it - DRM_BRIDGE_ATTACH_NO_CONNECTOR. > > It would be preferred that we moved the relevant bridge drivers to the > new model no so you did not need to support the old model in the driver. Hello Sam, Thank you very much for the clarification! To be honest, I was a bit confused by the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag. Perhaps would be nice if the code told explicitly that drivers should use the new flag because it appeared to me that adding bridge functions to the DRM driver is a step backwards since looks like it involves writing some more code :) > If you help identify the bridge drivers we could migrate them to the new > model and you could help testing? > > What bridge drivers will be used for tegra? It's lvds-encoder of bridge/lvds-codec.c, which supports the new model. I'll try to move to the new model in v3. Thanks again!
