14.04.2020 18:47, Thierry Reding пишет: > On Fri, Apr 10, 2020 at 02:44:16AM +0300, Dmitry Osipenko wrote: >> 09.04.2020 20:52, Thierry Reding пишет: >> ... >>> tegra210_emc_debugfs_init(emc); >>> >>> + cd = devm_thermal_of_cooling_device_register(emc->dev, np, "emc", emc, >>> + &tegra210_emc_cd_ops); >>> + if (IS_ERR(cd)) { >>> + err = PTR_ERR(cd); >>> + dev_err(emc->dev, "failed to register cooling device: %d\n", >>> + err); >> >>> + goto detach; >> >> I think it's not really worthwhile to fail whole EMC driver because of >> the failed CDEV. > > Well, we do kind of need this cooling device mechanism in order for the > memory to continue to operate properly at high temperatures. It's also > very unlikely that this will ever fail, so I don't see any harm in > making this mandatory. Fair enough.