14.04.2020 18:05, Thierry Reding пишет: ... >> What about replacing those barely readable concatenated macros with a >> raw values? >> >> Like: >> >> TRIM_REG(brlshft_idx, ob_ddll_long_dq_rank_mask, ...) > > That's just going to move the complexity from the macros to the > callsites, isn't it? > > I suppose I could spend a few cycles trying to make this a little more > readable, but to be frank, the complexity in this driver is already so > high that this doesn't really make much of a difference, in my opinion. I can't guarantee that the final result will be excellent, but I'd try to turn that macro into the function and then use the raw HW values instead of the defines. It looks to me that the result at least should be better.
