On Fri, Apr 10, 2020 at 05:25:06PM +0300, Dmitry Osipenko wrote:
> 09.04.2020 20:52, Thierry Reding пишет:
> ...
> > +static int tegra210_emc_remove(struct platform_device *pdev)
> > +{
> > + struct tegra210_emc *emc = platform_get_drvdata(pdev);
> > +
> > + debugfs_remove_recursive(emc->debugfs.root);
> > + tegra210_clk_emc_detach(emc->clk);
>
> It's great that you want to make this driver modular, but I don't think
> that it's a good idea to suddenly rip off the EMC clock from the users.
>
> It should be better to simply disallow unloading of this driver once
> it's loaded.
That's not what we're doing. The clock is going to stay around and users
will be able to access it. The only thing that the above does is take
away the possibility to change the rate of the EMC clock.
So I think this actually makes this really nice both for testing that
unload/reload works and it also gives users an easy way to disable EMC
frequency scaling by simply blacklisting the module.
Thierry
Attachment:
signature.asc
Description: PGP signature
