On Thu, Apr 09, 2020 at 10:00:13PM +0300, Dmitry Osipenko wrote:
> 09.04.2020 20:52, Thierry Reding пишет:
> ...
> > +static void tegra210_emc_debugfs_init(struct tegra210_emc *emc)
> > +{
> > + struct device *dev = emc->dev;
> > + unsigned int i;
> > + int err;
> > +
> > + emc->debugfs.min_rate = ULONG_MAX;
> > + emc->debugfs.max_rate = 0;
> > +
> > + for (i = 0; i < emc->num_timings; i++) {
> > + if (emc->timings[i].rate * 1000UL < emc->debugfs.min_rate)
> > + emc->debugfs.min_rate = emc->timings[i].rate * 1000UL;
> > +
> > + if (emc->timings[i].rate * 1000UL > emc->debugfs.max_rate)
> > + emc->debugfs.max_rate = emc->timings[i].rate * 1000UL;
> > + }
> > +
> > + if (!emc->num_timings) {
> > + emc->debugfs.min_rate = clk_get_rate(emc->clk);
> > + emc->debugfs.max_rate = emc->debugfs.min_rate;
> > + }
> > +
> > + err = clk_set_rate_range(emc->clk, emc->debugfs.min_rate,
> > + emc->debugfs.max_rate);
> > + if (err < 0) {
> > + dev_err(dev, "failed to set rate range [%lu-%lu] for %pC\n",
> > + emc->debugfs.min_rate, emc->debugfs.max_rate,
> > + emc->clk);
> > + return;
> > + }
> > +
> > + emc->debugfs.root = debugfs_create_dir("emc", NULL);
> > + if (!emc->debugfs.root) {
> > + dev_err(dev, "failed to create debugfs directory\n");
> > + return;
> > + }
> > +
> > + debugfs_create_file("available_rates", S_IRUGO, emc->debugfs.root, emc,
> > + &tegra210_emc_debug_available_rates_fops);
> > + debugfs_create_file("min_rate", S_IRUGO | S_IWUSR, emc->debugfs.root,
> > + emc, &tegra210_emc_debug_min_rate_fops);
> > + debugfs_create_file("max_rate", S_IRUGO | S_IWUSR, emc->debugfs.root,
> > + emc, &tegra210_emc_debug_max_rate_fops);
>
> I assume you used the checkpatch before sending the patches, no?
I have a pre-commit hook that runs checkpatch, but for some reason it
was disabled. Fixed these to be numeric now.
> I sent out a patch recently to make the permissions readable, please
> take a look if you haven't seen it yet.
>
> https://patchwork.ozlabs.org/patch/1254301/
I've applied this now.
Thierry
Attachment:
signature.asc
Description: PGP signature
