23.03.2020 16:42, Thierry Reding пишет: > On Fri, Mar 20, 2020 at 06:38:32PM +0300, Dmitry Osipenko wrote: >> 20.03.2020 18:11, Dmitry Osipenko пишет: >>> 20.03.2020 16:34, Thierry Reding пишет: >>>> From: Thierry Reding <treding@xxxxxxxxxx> >>>> >>>> Currently this only supports a single watchdog, which uses a timer in >>>> the background for countdown. Eventually the timers could be used for >>>> various time-keeping tasks, but by default the architected timer will >>>> already provide that functionality. >>>> >>>> Signed-off-by: Thierry Reding <treding@xxxxxxxxxx> >>>> --- >>> >>> ... >>>> +config TEGRA186_TIMER >>>> + bool "NVIDIA Tegra186 timer driver" >>> >>> tristate? >>> >>>> + depends on ARCH_TEGRA || COMPILE_TEST >>> >>> depends on WATCHDOG && WATCHDOG_CORE? >> >> Actually `select WATCHDOG_CORE` for the WATCHDOG_CORE. > > WATCHDOG_CORE is user-visible, so it's not safe to select it. Any reason > depends on WATCHDOG && WATCHDOG_CORE wouldn't work? I guess a dependency > on WATCHDOG_CORE would be enough because that itself already depends on > WATCHDOG. It looks to that should be much better if you could factor out all the watchdog functionality into the drivers/watchdog, like it's done in a case of MC / SMMU drivers for example.