Re: [PATCH 6/9] pinctrl: tegra: Pass struct tegra_pmx for pin range check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 3/19/2020 5:57 PM, Thierry Reding wrote:
External email: Use caution opening links or attachments


From: Thierry Reding <treding@xxxxxxxxxx>

Pass the struct tegra_pmx when checking for the pin range in device
tree. This makes the call site a bit easier to read and will help keep
that readability in a subsequent patch.

Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>
---
  drivers/pinctrl/tegra/pinctrl-tegra.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/pinctrl/tegra/pinctrl-tegra.c b/drivers/pinctrl/tegra/pinctrl-tegra.c
index cefbbb8d1a68..c8246cc2c4fd 100644
--- a/drivers/pinctrl/tegra/pinctrl-tegra.c
+++ b/drivers/pinctrl/tegra/pinctrl-tegra.c
@@ -689,12 +689,12 @@ const struct dev_pm_ops tegra_pinctrl_pm = {
         .resume = &tegra_pinctrl_resume
  };

-static bool gpio_node_has_range(const char *compatible)
+static bool tegra_pinctrl_gpio_node_has_range(struct tegra_pmx *pmx)
  {
         struct device_node *np;
         bool has_prop = false;

-       np = of_find_compatible_node(NULL, NULL, compatible);
+       np = of_find_compatible_node(NULL, NULL, pmx->soc->gpio_compatible);
         if (!np)
                 return has_prop;

@@ -794,7 +794,7 @@ int tegra_pinctrl_probe(struct platform_device *pdev,

         tegra_pinctrl_clear_parked_bits(pmx);

-       if (!gpio_node_has_range(pmx->soc->gpio_compatible))
+       if (!tegra_pinctrl_gpio_node_has_range(pmx))
                 pinctrl_add_gpio_range(pmx->pctl, &tegra_pinctrl_gpio_range);

         platform_set_drvdata(pdev, pmx);
--
2.24.1

Tested-by: Vidya Sagar <vidyas@xxxxxxxxxx>



[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux