On Fri, Mar 13, 2020 at 02:16:16PM +0000, Jon Hunter wrote: > Hi Lee, Daniel, > > On 24/02/2020 14:37, Daniel Thompson wrote: > > On Mon, Feb 24, 2020 at 02:07:48PM +0000, Jon Hunter wrote: > >> If probing the LP885x backlight fails after the regulators have been > >> enabled, then the following warning is seen when releasing the > >> regulators ... > >> > >> WARNING: CPU: 1 PID: 289 at drivers/regulator/core.c:2051 _regulator_put.part.28+0x158/0x160 > >> Modules linked in: tegra_xudc lp855x_bl(+) host1x pwm_tegra ip_tables x_tables ipv6 nf_defrag_ipv6 > >> CPU: 1 PID: 289 Comm: systemd-udevd Not tainted 5.6.0-rc2-next-20200224 #1 > >> Hardware name: NVIDIA Jetson TX1 Developer Kit (DT) > >> > >> ... > >> > >> Fix this by ensuring that the regulators are disabled, if enabled, on > >> probe failure. > >> > >> Finally, ensure that the vddio regulator is disabled in the driver > >> remove handler. > >> > >> Signed-off-by: Jon Hunter <jonathanh@xxxxxxxxxx> > > > > Reviewed-by: Daniel Thompson <daniel.thompson@xxxxxxxxxx> > I received a bounce from Milo's email and so I am not sure that his > email address is still valid. > > Can either of you pick this up? Lee generally starts to hoover up patches about this stage in the dev cycle so I'd expect this to move fairly soon. > Not sure if we should update the MAINTAINERS as well? Sounds like a good plan, yes. Daniel.
