On Mon, Jan 27, 2020 at 2:18 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Sun, Jan 26, 2020 at 09:35:48PM -0500, Peter Geis wrote:
> > The ci_hdrc_tegra driver does not currently support dual role mode, but
> > it does not explicitly prevent its use.
> > Certain devices support dual role mode, but not automatic role switch.
> > This can cause the device to lock up during initialization of the
> > driver.
> >
> > Detect this state by checking for the extcon phandle when dual role mode
> > is set to otg.
> > If it doesn't exist request the driver to only enable manual role
> > switching.
> >
> > Fixes: dfebb5f ("usb: chipidea: Add support for Tegra20/30/114/124")
>
> Please use 12 digits for kernel sha1 values, this should be:
> Fixes: dfebb5f43a78 ("usb: chipidea: Add support for Tegra20/30/114/124")
Understood, thank you.
I will ensure that is the case in the future.
>
> As proof of the need of this, just using the values you gave here causes
> git to complain:
>
> $ git show dfebb5f
> error: short SHA1 dfebb5f is ambiguous
> hint: The candidates are:
> hint: dfebb5f43a78 commit 2017-08-16 - usb: chipidea: Add support for Tegra20/30/114/124
> hint: dfebb5fec744 tree
> fatal: ambiguous argument 'dfebb5f': unknown revision or path not in the working tree.
>
> thanks,
>
> greg k-h
