On Wed, Dec 18, 2019 at 12:04 PM Ben Dooks (Codethink) <ben.dooks@xxxxxxxxxxxxxxx> wrote: > The functions should have __iomem on the register pointer > so add that to silence the following sparse warnings: > > drivers/pinctrl/tegra/pinctrl-tegra.c:657:22: warning: incorrect type in assignment (different address spaces) > drivers/pinctrl/tegra/pinctrl-tegra.c:657:22: expected unsigned int [usertype] *regs > drivers/pinctrl/tegra/pinctrl-tegra.c:657:22: got void [noderef] <asn:2> * > drivers/pinctrl/tegra/pinctrl-tegra.c:659:42: warning: incorrect type in argument 1 (different address spaces) > drivers/pinctrl/tegra/pinctrl-tegra.c:659:42: expected void const volatile [noderef] <asn:2> *addr > drivers/pinctrl/tegra/pinctrl-tegra.c:659:42: got unsigned int [usertype] * > drivers/pinctrl/tegra/pinctrl-tegra.c:675:22: warning: incorrect type in assignment (different address spaces) > drivers/pinctrl/tegra/pinctrl-tegra.c:675:22: expected unsigned int [usertype] *regs > drivers/pinctrl/tegra/pinctrl-tegra.c:675:22: got void [noderef] <asn:2> * > drivers/pinctrl/tegra/pinctrl-tegra.c:677:25: warning: incorrect type in argument 2 (different address spaces) > drivers/pinctrl/tegra/pinctrl-tegra.c:677:25: expected void volatile [noderef] <asn:2> *addr > drivers/pinctrl/tegra/pinctrl-tegra.c:677:25: got unsigned int [usertype] * > > Signed-off-by: Ben Dooks (Codethink) <ben.dooks@xxxxxxxxxxxxxxx> > --- > Cc: Linus Walleij <linus.walleij@xxxxxxxxxx> > Cc: Thierry Reding <thierry.reding@xxxxxxxxx> > Cc: Jonathan Hunter <jonathanh@xxxxxxxxxx> > Cc: Dmitry Osipenko <digetx@xxxxxxxxx> > Cc: linux-gpio@xxxxxxxxxxxxxxx > Cc: linux-tegra@xxxxxxxxxxxxxxx Patch applied with the ACKs. Yours, Linus Walleij