On 10/12/2019 19:52, Arnd Bergmann wrote: > When CONFIG_SPI is disabled, the newly added code for the DSP > firmware loading fails to link: > > ERROR: "rt5677_spi_hotword_detected" [sound/soc/codecs/snd-soc-rt5677.ko] undefined! > ERROR: "rt5677_spi_write" [sound/soc/codecs/snd-soc-rt5677.ko] undefined! Would it be better if the above functions or the functions that call these are conditional on CONFIG_SND_SOC_RT5677_SPI? > Add a dependency to prevent this configuration. > > Note: the does not work with the DT probing, as there is no binding Are you missing 'SPI' or something here? > for the SPI half of the driver, but nothing seems to be using that > with the mainline kernel anyway. >From a Tegra perspective, given that we don't use SPI in conjunction with the rt5677 codec, only I2C so far, I am not sure we should make the tegra_rt5677 driver dependent upon it. We should be able to operate without the SPI bits enabled. Cheers Jon -- nvpublic
