Re: [PATCH] drm/tegra: vic: Export module device table

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 22, 2019 at 02:32:15PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@xxxxxxxxxx>
> 
> Export the module device table to ensure the VIC compatible strings are
> listed in the module's aliases table. This in turn causes the driver to
> be automatically loaded on boot if VIC is the only enabled subdevice of
> the logical host1x DRM device.
> 
> Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>

Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx>

I noticed that the drm subdev driver also lacks the matches. How does that
work? Just by getting loaded when any of the subdev drivers match?
-Daniel

> ---
>  drivers/gpu/drm/tegra/vic.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tegra/vic.c b/drivers/gpu/drm/tegra/vic.c
> index 9444ba183990..c4d82b8b3065 100644
> --- a/drivers/gpu/drm/tegra/vic.c
> +++ b/drivers/gpu/drm/tegra/vic.c
> @@ -386,13 +386,14 @@ static const struct vic_config vic_t194_config = {
>  	.supports_sid = true,
>  };
>  
> -static const struct of_device_id vic_match[] = {
> +static const struct of_device_id tegra_vic_of_match[] = {
>  	{ .compatible = "nvidia,tegra124-vic", .data = &vic_t124_config },
>  	{ .compatible = "nvidia,tegra210-vic", .data = &vic_t210_config },
>  	{ .compatible = "nvidia,tegra186-vic", .data = &vic_t186_config },
>  	{ .compatible = "nvidia,tegra194-vic", .data = &vic_t194_config },
>  	{ },
>  };
> +MODULE_DEVICE_TABLE(of, tegra_vic_of_match);
>  
>  static int vic_probe(struct platform_device *pdev)
>  {
> @@ -516,7 +517,7 @@ static const struct dev_pm_ops vic_pm_ops = {
>  struct platform_driver tegra_vic_driver = {
>  	.driver = {
>  		.name = "tegra-vic",
> -		.of_match_table = vic_match,
> +		.of_match_table = tegra_vic_of_match,
>  		.pm = &vic_pm_ops
>  	},
>  	.probe = vic_probe,
> -- 
> 2.23.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch



[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux