On 15/11/2019 16:26, Dmitry Osipenko wrote:
> Trying to suspend driver results in a crash if timings aren't available in
> device-tree.
>
> Reported-by: Jon Hunter <jonathanh@xxxxxxxxxx>
> Fixes: e34212c75a68 ("memory: tegra: Introduce Tegra30 EMC driver")
> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx>
> ---
> drivers/memory/tegra/tegra30-emc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/memory/tegra/tegra30-emc.c b/drivers/memory/tegra/tegra30-emc.c
> index 6929980bf907..0b6a5e451ea3 100644
> --- a/drivers/memory/tegra/tegra30-emc.c
> +++ b/drivers/memory/tegra/tegra30-emc.c
> @@ -1093,7 +1093,7 @@ static int tegra_emc_probe(struct platform_device *pdev)
> if (of_get_child_count(pdev->dev.of_node) == 0) {
> dev_info(&pdev->dev,
> "device-tree node doesn't have memory timings\n");
> - return 0;
> + return -ENODEV;
> }
>
> np = of_parse_phandle(pdev->dev.of_node, "nvidia,memory-controller", 0);
>
Thanks for the fix!
Acked-by: Jon Hunter <jonathanh@xxxxxxxxxx>
Tested-by: Jon Hunter <jonathanh@xxxxxxxxxx>
Jon
--
nvpublic
