Hi Jon > >> I am seeing an audio regression on -next and bisect is pointing to > >> this commit. I am seeing the following crash on boot during probe > >> deferral of the soundcard ... > > > > It seems timing bug. > > I have a plan to post below patch if my current posting patch are accepted, > > but it seems it is necessary immediately. > > I believe your issue will be solved by this patch, > > but can you please test it ? > > I will formally post it with your tested-by if it was OK. > > > > # It will be more cleanuped in the future, > > # but it needs more other cleanup patches... > > > > -------------------- > > Subject: [PATCH] ASoC: soc-core: care card_probed at soc_cleanup_card_resources() > > > > soc_cleanup_card_resources() will call card->remove(), but it should be > > called if card->probe() or card->late_probe() are called. > > snd_soc_bind_card() might be error before calling > > card->probe() / card->late_probe(). > > In that time, card->remove() will be called. > > This patch adds card_probed parameter to judge it. > > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > > --- > > sound/soc/soc-core.c | 15 ++++++++++----- > > 1 file changed, 10 insertions(+), 5 deletions(-) > > Thanks! I can confirm that this works, so ... > > Tested-by: Jon Hunter <jonathanh@xxxxxxxxxx> Thanks. I will post formal patch, soon Thank you for your help !! Best regards --- Kuninori Morimoto
