04.10.2019 03:00, Peter Geis пишет:
> Enable PINCTRL_SINGLE by default, this is required to enable
> GENERIC_PINCTRL.
> This prevents tegra_defconfig build from failing with the following
> error:
> drivers/soc/tegra/pmc.c:1753:3: error: ‘const struct pinconf_ops’ has no member named ‘is_generic’
> .is_generic = true,
>
> Signed-off-by: Peter Geis <pgwipeout@xxxxxxxxx>
> ---
> arch/arm/configs/tegra_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/tegra_defconfig b/arch/arm/configs/tegra_defconfig
> index 9a2f11a780a8..c9e6d0f8917b 100644
> --- a/arch/arm/configs/tegra_defconfig
> +++ b/arch/arm/configs/tegra_defconfig
> @@ -130,6 +130,7 @@ CONFIG_SPI=y
> CONFIG_SPI_TEGRA114=y
> CONFIG_SPI_TEGRA20_SFLASH=y
> CONFIG_SPI_TEGRA20_SLINK=y
> +CONFIG_PINCTRL_SINGLE=y
> CONFIG_PINCTRL_AS3722=y
> CONFIG_PINCTRL_PALMAS=y
> CONFIG_GPIO_SYSFS=y
>
Hello Peter,
The ‘is_generic’ is hidden by CONFIG_GENERIC_PINCONF, this option should be selected by
the pinctrl drivers. Tegra's pinctrl doesn't select that option, hence I can see the
non-multiplatform build failing to compile.
Thus the fix should be something like that:
diff --git a/drivers/pinctrl/tegra/Kconfig b/drivers/pinctrl/tegra/Kconfig
index a67d0d9ae8cd..98e3ca67deb1 100644
--- a/drivers/pinctrl/tegra/Kconfig
+++ b/drivers/pinctrl/tegra/Kconfig
@@ -1,6 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only
config PINCTRL_TEGRA
bool
+ select GENERIC_PINCONF
select PINMUX
select PINCONF
This change will force-enable CONFIG_GENERIC_PINCONF whenever CONFIG_PINCTRL_TEGRA is enabled.
