Hi Thierry, On Mon, Sep 16, 2019 at 05:54:43PM +0200, Thierry Reding wrote: > > Joerg, to summarize: the proposal here is to move the declaration of the > > iommu_fwspec outside of the IOMMU_API guard and provide a dummy > > implementation of dev_iommu_fwspec_get() to allow this code to be built > > without the #ifdef guards. We had discussed something similar about 5 > > years back and at the time you had been opposed: > > > > https://lore.kernel.org/linux-iommu/1406897113-20099-1-git-send-email-thierry.reding@xxxxxxxxx/ > > > > The case here is slightly different and a lot of time has passed since, > > so just wanted to ask if your opinion here is the same, or whether you > > would accept a patch to make this buildable without resorting to > > #ifdef'ery. This is about DRM, so if it is fine to build drm/nouveau without IOMMU-API I am also fine with dummys for dev_iommu_fwspec_get() and a dummy 'struct iommu_fwspec'. Regards, Joerg
