From: Jakub Kicinski <jakub.kicinski@xxxxxxxxxxxxx> Date: Sep/22/2019, 23:31:32 (UTC+00:00) > On Fri, 20 Sep 2019 19:01:27 +0200, Thierry Reding wrote: > > From: Thierry Reding <treding@xxxxxxxxxx> > > > > The size of individual pages in the page pool in given by an order. The > > order is the binary logarithm of the number of pages that make up one of > > the pages in the pool. However, the driver currently passes the number > > of pages rather than the order, so it ends up wasting quite a bit of > > memory. > > > > Fix this by taking the binary logarithm and passing that in the order > > field. > > > > Signed-off-by: Thierry Reding <treding@xxxxxxxxxx> > > Since this is a fix could we get a Fixes tag pointing to the commit > which introduced the regression? This would be: 2af6106ae949 ("net: stmmac: Introducing support for Page Pool") Can you please resubmit Thierry ? --- Thanks, Jose Miguel Abreu