From: Thierry Reding <thierry.reding@xxxxxxxxx> Date: Sep/09/2019, 20:11:27 (UTC+00:00) > On Mon, Sep 09, 2019 at 04:07:04PM +0000, Jose Abreu wrote: > > From: Thierry Reding <thierry.reding@xxxxxxxxx> > > Date: Sep/09/2019, 16:25:45 (UTC+00:00) > > > > > @@ -92,6 +92,7 @@ struct stmmac_dma_cfg { > > > int fixed_burst; > > > int mixed_burst; > > > bool aal; > > > + bool eame; > > > > bools should not be used in struct's, please change to int. > > Huh? Since when? "aal" right above it is also bool. Can you provide a > specific rationale for why we shouldn't use bool in structs? Please see https://lkml.org/lkml/2017/11/21/384. --- Thanks, Jose Miguel Abreu