Re: [PATCH] Add symlinks for Tegra VIC firmware binaries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 02 Sep 2019 09:47:18 +0200,
Thierry Reding wrote:
> 
> On Fri, Aug 30, 2019 at 02:05:15PM +0200, Takashi Iwai wrote:
> > On Fri, 30 Aug 2019 12:33:50 +0200,
> > Thierry Reding wrote:
> > > 
> > > I've noticed that the current Link: mechanism completely ignores the
> > > target part of the link. Was this intended to allow creating symlinks
> > > dynamically when copying the firmware, rather than just copying any
> > > existing symlinks themselves?
> > 
> > That's a kind of intentional; the script doesn't validate by itself
> > but just installs to the target directory.  And the cp -d option
> > preserves the symlink as-is, so it should work as long as the original
> > symlink is correctly set up.
> 
> Perhaps some code could be added to create the symlinks if the "-> foo"
> part was specified and no symlink exists.

Yeah, it sounds like a good idea.

> Not a big deal, I just think it's a bit redundant to basically have all
> the symlink information in the WHENCE file and in the filesystem. That's
> especially annoying if both get out of sync.
> 
> I'll volunteer to write that patch if you think it'd be a worthwhile
> addition.

I'm for it but leave the decision to Josh :)


Thanks!

Takashi



[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux