Re: [PATCH 1/3] arm64: tegra: Add unit-address for CBB on Tegra194

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 26, 2019 at 12:16:16PM +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@xxxxxxxxxx>
> 
> The control back-bone (CBB) starts at physical address 0, so give it a
> unit-address to comply with standard naming practices checked for by the
> device tree compiler.
> 
> Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>
> ---
>  .../arm64/boot/dts/nvidia/tegra194-p2888.dtsi | 20 +++++++++----------
>  .../boot/dts/nvidia/tegra194-p2972-0000.dts   |  2 +-
>  arch/arm64/boot/dts/nvidia/tegra194.dtsi      |  2 +-
>  3 files changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi b/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi
> index 62e07e1197cc..02f6a8f0d741 100644
> --- a/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi
> +++ b/arch/arm64/boot/dts/nvidia/tegra194-p2888.dtsi
> @@ -8,17 +8,17 @@
>  	compatible = "nvidia,p2888", "nvidia,tegra194";
>  
>  	aliases {
> -		sdhci0 = "/cbb/sdhci@3460000";
> -		sdhci1 = "/cbb/sdhci@3400000";
> +		sdhci0 = "/cbb@0/sdhci@3460000";
> +		sdhci1 = "/cbb@0/sdhci@3400000";
>  		serial0 = &tcu;
>  		i2c0 = "/bpmp/i2c";
> -		i2c1 = "/cbb/i2c@3160000";
> -		i2c2 = "/cbb/i2c@c240000";
> -		i2c3 = "/cbb/i2c@3180000";
> -		i2c4 = "/cbb/i2c@3190000";
> -		i2c5 = "/cbb/i2c@31c0000";
> -		i2c6 = "/cbb/i2c@c250000";
> -		i2c7 = "/cbb/i2c@31e0000";
> +		i2c1 = "/cbb@0/i2c@3160000";
> +		i2c2 = "/cbb@0/i2c@c240000";
> +		i2c3 = "/cbb@0/i2c@3180000";
> +		i2c4 = "/cbb@0/i2c@3190000";
> +		i2c5 = "/cbb@0/i2c@31c0000";
> +		i2c6 = "/cbb@0/i2c@c250000";
> +		i2c7 = "/cbb@0/i2c@31e0000";
>  	};
[...]

There are aliases in tegra194.dtsi like gen1_i2c, maybe they could
be used here?

Best Regards,
Michał Mirosław



[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux