Re: [PATCH v2] drm/tegra: sor: Enable HDA interrupts at plugin

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Dmitry, I have pushed new patch set v3 (https://patchwork.ozlabs.org/patch/1135605/). Request you to kindly review.

Thanks.

On 7/23/2019 3:48 PM, Dmitry Osipenko wrote:
23.07.2019 13:11, Viswanath L пишет:
Thanks for your comments, Dmitry. Please see my responses inline.

On 7/23/2019 6:00 AM, Dmitry Osipenko wrote:
22.07.2019 12:27, Viswanath L пишет:
HDMI plugout calls runtime suspend, which clears interrupt registers
and causes audio functionality to break on subsequent plugin; setting
interrupt registers in sor_audio_prepare() solves the issue
Hello Viswanath,

A dot should be in the end of sentence, please. And should be better to
s/plugin/plug-in/ in the commit's message/title because 'plugin' sounds
as a noun.
[VL] Yes, I'll make the above changes.
Please don't version patch as v2 if v1 wasn't ever sent out.
[VL] Now that I have sent v2, shall I continue with v2 for the next
patch? Apologies for this oversight.
v3 should be good.

You should add a stable tag here to get patch backported into stable
kernel versions:

Cc: <stable@xxxxxxxxxxxxxxx>
[VL] Yes, will add.
Signed-off-by: Viswanath L <viswanathl@xxxxxxxxxx>
The kernel upstreaming rules require a full name. I'm pretty sure that L
isn't yours surname.
[VL] My name appears as "Viswanath L" in all company records and email
lists. I would strongly prefer to keep it this way, unless that is an
absolute no-no.
I guess it should be okay, but a full name is much more preferable.




[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux