On Fri, Jun 28, 2019 at 5:58 PM Lina Iyer <ilina@xxxxxxxxxxxxxx> wrote: > >I might be wrong, but then I need to see some example > >of hierarchies that need something more than what the > >gpiolib core is providing and idiomatic enough that it can't > >be rewritten and absolutely must have its own ops. > > Here is an example of what I am working on [1]. The series is based on > this patch. What I want to point out is the .alloc function. The TLMM > irqchip's parent could be a PDC or a MPM depending on the QCOM SoC > architecture. They behave differently. The PDC takes over for the GPIO > and handles the monitoring etc, while the MPM comes into play only after > the SoC is in low power therefore TLMM needs to do its job. The way to > cleanly support both of themis to have our own .alloc functions to help > understand the the wakeup-parent irqchip's behavior. > > Since I need my own .ops, it makes the function below irrelevant to > gpiolib. While I would still need a function to translate to parent > hwirq, I don't see it any beneficial to gpiolib. OK I see, I am holding the patch set back for v5.4 so we can make sure that yours and also Brian Masney's drivers will be able to work with this. Let's try to get this in shape for the next kernel. Yours, Linus Walleij
