On Thu, Jun 13, 2019 at 10:28 AM 'Nathan Huckleberry' via Clang Built Linux <clang-built-linux@xxxxxxxxxxxxxxxx> wrote: > The only usage of this variable is from within an ifdef. > It seems logical to move the variable into the ifdef as well. Thanks for the patch, I agree but have the same thoughts as in: https://lkml.org/lkml/2019/6/13/1438 > +#ifdef CONFIG_ARCH_TEGRA_124_SOC > static const unsigned long tegra124_mc_emem_regs[] = { > MC_EMEM_ARB_CFG, > MC_EMEM_ARB_OUTSTANDING_REQ, > @@ -54,6 +55,7 @@ static const unsigned long tegra124_mc_emem_regs[] = { > MC_EMEM_ARB_MISC1, > MC_EMEM_ARB_RING1_THROTTLE > }; > +#endif -- Thanks, ~Nick Desaulniers
