04.06.2019 18:31, Thierry Reding пишет:
> From: Thierry Reding <treding@xxxxxxxxxx>
>
> When deferring probe, avoid logging a confusing error message. While at
> it, make the error message more informational.
>
> Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>
> ---
> drivers/gpu/host1x/dev.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/host1x/dev.c b/drivers/gpu/host1x/dev.c
> index c55e2d634887..5a3f797240d4 100644
> --- a/drivers/gpu/host1x/dev.c
> +++ b/drivers/gpu/host1x/dev.c
> @@ -247,8 +247,11 @@ static int host1x_probe(struct platform_device *pdev)
>
> host->clk = devm_clk_get(&pdev->dev, NULL);
> if (IS_ERR(host->clk)) {
> - dev_err(&pdev->dev, "failed to get clock\n");
> err = PTR_ERR(host->clk);
> +
> + if (err != -EPROBE_DEFER)
> + dev_err(&pdev->dev, "failed to get clock: %d\n", err);
> +
> return err;
> }
The clock driver should be available at the time of host1x's probing on
all Tegra's because it is one of essential core drivers that become
available early during boot.
I guess you're making this change for T186, is it because the BPMP
driver's probe getting deferred? If yes, won't it be possible to fix the
defer of the clock driver instead of making such changes in all of the
affected drivers?
[it appeared to me that first email got dropped by gmail, so I'm
re-sending it second time just in a case]
--
Dmitry
