Re: [PATCH] sdhci: tegra: Do not log error message on deferred probe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 04, 2019 at 05:34:46PM +0200, Thierry Reding wrote:
> From: Thierry Reding <treding@xxxxxxxxxx>
> 
> Recent changes have made it much more probably that clocks are not

Ugh... s/probably/probable/. Adrian, Ulf, do you want me to resend just
for that if there are no further comments, or could you ammend that when
applying?

Thierry

> available yet when the SDHCI driver is first probed. However, that
> is a situation that the driver can cope with just fine.
> 
> To avoid confusion, don't output an error when this happens.
> 
> Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>
> ---
>  drivers/mmc/host/sdhci-tegra.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c
> index 10d7aaf68bab..8a6a51bc038b 100644
> --- a/drivers/mmc/host/sdhci-tegra.c
> +++ b/drivers/mmc/host/sdhci-tegra.c
> @@ -1550,8 +1550,11 @@ static int sdhci_tegra_probe(struct platform_device *pdev)
>  
>  	clk = devm_clk_get(mmc_dev(host->mmc), NULL);
>  	if (IS_ERR(clk)) {
> -		dev_err(mmc_dev(host->mmc), "clk err\n");
>  		rc = PTR_ERR(clk);
> +
> +		if (rc != -EPROBE_DEFER)
> +			dev_err(&pdev->dev, "failed to get clock: %d\n", rc);
> +
>  		goto err_clk_get;
>  	}
>  	clk_prepare_enable(clk);
> -- 
> 2.21.0
> 

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [ARM Kernel]     [Linux ARM]     [Linux ARM MSM]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux