30.05.2019 14:36, Dmitry Osipenko пишет: > 30.05.2019 9:14, Bitan Biswas пишет: >> Fix checkpatch.pl warning(s)/error(s)/check(s) in i2c-tegra.c >> except for BUG/BUG_ON checks > > Please turn the BUG_ON's into WARN_ON's. The machine won't go on fire, > hence there is absolutely no good reason in making system unusable on a > software bug. BUG_ON may be more useful for development, but not for a > casual daily usage. > >> Signed-off-by: Bitan Biswas <bbiswas@xxxxxxxxxx> >> --- > >> @@ -1034,7 +1038,7 @@ static int tegra_i2c_xfer_msg(struct tegra_i2c_dev *i2c_dev, >> u32 *buffer = NULL; >> int err = 0; >> bool dma; >> - u16 xfer_time = 100; >> + u16 xfer_tm = 100; > > What's wrong with the "time"? I'm finding the "xfer_tm" as a very > unintuitive naming. > Also, please don't version patch as v2 if v1 was never sent out.
