Hello Hans Verkuil,
The patch 4d34c9267db7: "media: tegra_cec: use new
cec_notifier_parse_hdmi_phandle helper" from Apr 10, 2019, leads to
the following static checker warning:
drivers/media/platform/tegra-cec/tegra_cec.c:337 tegra_cec_probe()
warn: 'hdmi_dev' is an error pointer or valid
drivers/media/platform/tegra-cec/tegra_cec.c
328 static int tegra_cec_probe(struct platform_device *pdev)
329 {
330 struct device *hdmi_dev;
331 struct tegra_cec *cec;
332 struct resource *res;
333 int ret = 0;
334
335 hdmi_dev = cec_notifier_parse_hdmi_phandle(&pdev->dev);
336
337 if (!hdmi_dev)
^^^^^^^^^
This should be IS_ERR().
338 return -ENODEV;
339
340 cec = devm_kzalloc(&pdev->dev, sizeof(struct tegra_cec), GFP_KERNEL);
341
342 if (!cec)
343 return -ENOMEM;
regards,
dan carpenter
